-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: link LibUV #4963
feat: link LibUV #4963
Conversation
It is great to see libuv being integrated into the runtime! May I ask what is the goal? Cross-platform file/network/time IO? Or also non-blocking IO? |
@ydewit Yes, the ultimate goal is support for non-blocking IO. Note however that this PR only links against LibUV and it might take a very long time until we actually start building anything on top of it, so if you have need for asynchronous IO right now then it probably makes sense to explore alternatives such as lean-libuv for now. |
Mathlib CI status (docs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add to the docs page on building Lean that you need to have libuv installed right? Alternatively we could do something similar to the CaDiCal PR and declare libuv as an external project that gets downloaded and compiled by our build system directly.
Thanks, I've updated the build instructions. We don't want to build libuv as part of our build system, but use either system libraries (when building manually) or take static libraries from Nix (when creating release versions via CI), just as we do it with GMP. |
No description provided.