-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make loose docstrings into elaboration errors rather than parse errors #4975
Open
kmill
wants to merge
2
commits into
leanprover:master
Choose a base branch
from
kmill:loose_doc_comment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Aug 9, 2024
Mathlib CI status (docs):
|
!bench |
Here are the benchmark results for commit f1bb524. Benchmark Metric Change
====================================================
- parser instructions 6.3% (6414.6 σ)
+ stdlib fix level params -1.8% (-13.9 σ)
- stdlib instantiate metavars 1.6% (38.9 σ) |
… errors Now loose docstrings will not yield a confusing parser error and instead log an "unexpected docstring" elaboration error and continue processing. Furthermore, if the docstring is preceding the `in` command combinator, it will add a hint to the error: ``` unexpected doc string Hint: the docstring must come after '... in', immediately before the declaration that accepts a docstring. ``` Closes leanprover#3135
kmill
force-pushed
the
loose_doc_comment
branch
from
September 7, 2024 21:19
f1bb524
to
bd4c12d
Compare
!bench |
Here are the benchmark results for commit bd4c12d. Benchmark Metric Change
==================================================
- bv_decide_mul branch-misses 2.6% (13.5 σ)
- import Lean task-clock 14.1% (22.2 σ)
- import Lean wall-clock 14.1% (22.2 σ)
- parser instructions 6.3% (15429.4 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now loose docstrings will not yield a confusing parser error and instead log an "unexpected docstring" elaboration error and continue processing.
Furthermore, if the docstring is preceding the
in
command combinator, it will add a hint to the error:Closes #3135