refactor: WF.fix: use WellFoundedRelation.fixBy #5233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this defines
```
WellFoundedRelation.fixBy {α : Sort u} {β : Sort v} [WellFoundedRelation β] (f : α → β)
{C : α → Sort w} (F : ∀ x, (∀ y, WellFoundedRelation.rel (f y) (f x) → C y) → C x) (x : α) : C x
```
based on `WellFounded.fix`, `WellFoundedRelation` and `InvImage`. This
moves some logic from meta code in WF.Fix to this definitions, so mostly
a conceptual simplicification, with the effect that `invImage` should
no longer show up to the user (even with #5016 disabled.)
|
There is some rather hackish way in which |
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 2, 2024
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 7, 2024
|
Mathlib CI status (docs):
|
|
With #5234 for now off the roadmap, this refactoring isn’t so pressing anymore. Maybe some other time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this defines
based on
WellFounded.fix,WellFoundedRelationandInvImage. Thismoves some logic from meta code in WF.Fix to this definitions, so mostly
a conceptual simplicification, with the effect that
invImageshouldno longer show up to the user (even with #5016 disabled.)