chore: turn off [Inhabited β] : Inhabited (Sum α β) #5270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
awaiting-review
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 6, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 6, 2024
urkud
reviewed
Sep 6, 2024
leanprover-community-bot
added
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 6, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 6, 2024
|
Mathlib CI status (docs):
|
|
Closed in favour of #5284 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Alternative to #5270.
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Sep 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
After #5270, `partial` functions that use products of sums no longer compile with only `Nonempty` constraints on their arguments. These instances allow the compilation to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would disable the instances for
Inhabited (Sum α β)fromInhabited β, because this can easily result in non-defeq Inhabited instances by competing with the instance from the left-summand.I'm not sure whether this is a good idea or not: people might be surprised that this instance is missing.
An alternative would be an instance
[IsEmpty α] [Inhabited β] : Inhabited (Sum α β)that could only fire when the other instances couldn't. However this would either have to happen in Mathlib, or we'd need to moveIsEmptyup to Lean.See zulip discussion.