Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove @[simp] from forall_const #5309

Closed
wants to merge 1 commit into from
Closed

chore: remove @[simp] from forall_const #5309

wants to merge 1 commit into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 11, 2024

No description provided.

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 11, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 11, 2024 08:35 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 11, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 11, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5309
3cc1136
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 11, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5309
49e0a86
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 11, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em force-pushed the unsimp_forall_const branch from c7e5280 to 872a885 Compare September 12, 2024 01:13
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
fixes for leanprover/lean4#5309
dc7c7e8
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
fixes for leanprover/lean4#5309
8ec1a25
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 12, 2024 01:49 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 12, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5309
43de354
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5309
8f43a4f
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
bump batteries for leanprover/lean4#5309
24c6a42
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 12, 2024
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 12, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em
Copy link
Collaborator Author

kim-em commented Sep 16, 2024

This doesn't give much performance improvement over Mathlib, so is a bad idea.

@kim-em kim-em closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot