fix: invalid namespace completions #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 12, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 12, 2024
leanprover-community-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
builds-mathlib
|
Mathlib CI status (docs):
|
Kha
approved these changes
Sep 13, 2024
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Sep 16, 2024
This PR fixes an issue reported a while ago at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/.60Monad.2Emap.60.20is.20a.20namespace.3F/near/425662846 where `Monad.map` was incorrectly reported by the autocompletion as a namespace. The underlying issue is that `Monad.map` contains an internal declaration `_default`. This PR ensures that no namespaces are registered that only contain internal declarations. This also means that `open`ing namespaces that only contain internal declarations will now fail. The Mathlib adaption for this is a minor change where a declaration (i.e. a namespace that only contains internal declarations) was `open`ed by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported a while ago at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/.60Monad.2Emap.60.20is.20a.20namespace.3F/near/425662846 where
Monad.mapwas incorrectly reported by the autocompletion as a namespace.The underlying issue is that
Monad.mapcontains an internal declaration_default. This PR ensures that no namespaces are registered that only contain internal declarations.This also means that
opening namespaces that only contain internal declarations will now fail.The Mathlib adaption for this is a minor change where a declaration (i.e. a namespace that only contains internal declarations) was
opened by accident.