Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @[simp] lemmas about List.toArray #5472

Merged
merged 16 commits into from
Sep 26, 2024
Merged

feat: @[simp] lemmas about List.toArray #5472

merged 16 commits into from
Sep 26, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 25, 2024

We make sure that we can pull List.toArray out through all operations (well, for now "most" rather than "all"). As we also push Array.toList inwards, this hopefully has the effect of them cancelling as they meet, and simp naturally rewriting Array operations into List operations wherever possible.

This is not at all complete yet.

@kim-em kim-em requested a review from digama0 as a code owner September 25, 2024 11:16
@kim-em kim-em changed the title feat: @[simp] lemmas about List.toArray. feat: @[simp] lemmas about List.toArray Sep 25, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 25, 2024 11:36 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 25, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a3ca15d2b2d5460f7d9d2b32ca90c4ccbda21168 --onto 94de4ae96413d83bf0964d83500be0d3cdeff18f. (2024-09-25 11:38:43)

@kim-em kim-em added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit 5dea30f Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants