Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BitVec lemmas for smtUDiv, smtSDiv when denominator is zero #5616

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Oct 4, 2024

This PR is a follow-up to #5609, where we add lemmas characterizing smtUDiv and smtSDiv's behavior when the denominator is zero.

We build some slt theory, connecting it to msb for a clean proof. I chose not to characterize slt in terms of msb a simp lemma, since I anticipate use cases where we want to keep the arithmetic interpretation of slt.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 4, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 4, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f9048c132d381dfbefe581983d5a93d96c147300 --onto a4fda010f3d44c02393d5afd5cf05509989daf63. (2024-10-04 04:07:12)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase cb40ddad69cada36940844e538ddf09a304b007b --onto c779f3a039963fd38b03a78f635f0a7c36f24f42. (2024-11-08 15:34:19)

@kim-em
Copy link
Collaborator

kim-em commented Oct 29, 2024

Apologies for the delay. If you can fix the merge conflict we can merge this.

@Kha Kha added the awaiting-author Waiting for PR author to address issues label Nov 8, 2024
@bollu bollu requested a review from kim-em as a code owner November 8, 2024 15:12
@bollu
Copy link
Contributor Author

bollu commented Nov 8, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Nov 8, 2024
@kim-em kim-em added the changelog-library Library label Nov 10, 2024
@kim-em kim-em added this pull request to the merge queue Nov 10, 2024
Merged via the queue into leanprover:master with commit 78fe925 Nov 10, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants