-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BitVec lemmas for smtUDiv, smtSDiv when denominator is zero #5616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Oct 4, 2024
Mathlib CI status (docs):
|
tobiasgrosser
approved these changes
Oct 4, 2024
hargoniX
reviewed
Oct 4, 2024
Apologies for the delay. If you can fix the merge conflict we can merge this. |
awaiting-review |
github-actions
bot
added
awaiting-review
Waiting for someone to review the PR
and removed
awaiting-author
Waiting for PR author to address issues
labels
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
Waiting for someone to review the PR
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #5609, where we add lemmas characterizing
smtUDiv
andsmtSDiv
's behavior when the denominator is zero.We build some
slt
theory, connecting it tomsb
for a clean proof. I chose not to characterizeslt
in terms ofmsb
asimp
lemma, since I anticipate use cases where we want to keep the arithmetic interpretation ofslt
.