fix: liftCommandElabM now carries more state over
#5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `liftCommandElabM : CommandElabM α -> CoreM α` function now carries over macro scopes, the name generator, info trees, and messages. The infotrees and messages are updated only when `throwOnError` is false, which is a flag that causes `liftCommandElabM` to throw an error when a command logs an error message.
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 22, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2024
kmill
changed the title
liftCommandElabM now carries more stateliftCommandElabM now carries more state over
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 24, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 24, 2024
tobiasgrosser
pushed a commit
to opencompl/lean4
that referenced
this pull request
Oct 27, 2024
The `liftCommandElabM : CommandElabM α -> CoreM α` function now carries over macro scopes, the name generator, info trees, and messages. Adds a flag `throwOnError`, which is true by default. When it is true, then if the messages contain an error message, it is converted into an exception. In this case, the infotrees and messages are not carried over; the motivation is that `throwOnError` is likely used for synthetic syntax, and so the info and messages on errors will just be noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
liftCommandElabM : CommandElabM α -> CoreM αfunction now carries over macro scopes, the name generator, info trees, and messages.Adds a flag
throwOnError, which is true by default. When it is true, then if the messages contain an error message, it is converted into an exception. In this case, the infotrees and messages are not carried over; the motivation is thatthrowOnErroris likely used for synthetic syntax, and so the info and messages on errors will just be noise.