chore: move MessageData.ofConstName earlier
#5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes `MessageData.ofConstName` available without needing to import the pretty printer. Any code making use of `MessageData` can write `m!" ... {.ofConstName n} ... "` to have the name print with hover information. More error messages now have hover information.
* Now `.ofConstName` also has a boolean flag to make names print fully qualified. Default: false.
* Now `.ofConstName` will sanitize names that aren't constants. It is OK to use it in `"unknown constant '{.ofConstName constName}'"` errors.
Usability note: it is more user-friendly to have "has already been declared" errors report the fully qualified name. For this, write `m!"{.ofConstName n true} has already been declared"`.
kmill
requested review from
Vtec234,
leodemoura,
kim-em and
tydeu
as code owners
|
This salvages part of #5779 |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
MessageData.ofConstNameavailable without needing to import the pretty printer. Any code making use ofMessageDatacan writem!" ... {.ofConstName n} ... "to have the name print with hover information. More error messages now have hover information..ofConstNamealso has a boolean flag to make names print fully qualified. Default: false..ofConstNamewill sanitize names that aren't constants. It is OK to use it in"unknown constant '{.ofConstName constName}'"errors.Usability note: it is more user-friendly to have "has already been declared" errors report the fully qualified name. For this, write
m!"{.ofConstName n true} has already been declared".