Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unset trailing for simpa? "try this" suggestion #5907

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: unset trailing for simpa? "try this" suggestion #5907

merged 2 commits into from
Nov 8, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Oct 31, 2024

Closes #4581

@kmill kmill requested a review from digama0 as a code owner October 31, 2024 19:22
@kmill kmill added the awaiting-review Waiting for someone to review the PR label Oct 31, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 1, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 1, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f8242fa9652c4f61efb680b5137b71e655393d15 --onto 0fcee100e7ea382069854d91e854265c56b54428. (2024-11-01 01:14:55)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3f33cd6fcdcccd7ea50964ae1f60e16318eea6b5 --onto 0973ba3e4260327f69587813d6a67e5fade0c977. (2024-11-02 04:32:19)

@Kha Kha added this pull request to the merge queue Nov 8, 2024
Merged via the queue into leanprover:master with commit 85f2213 Nov 8, 2024
13 checks passed
@kim-em kim-em added the changelog-language Language features, tactics, and metaprograms label Jan 4, 2025
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@kmill @JovanGerb
fix: unset trailing for simpa? "try this" suggestion (leanprover#5907)
3ee6f71 
Closes leanprover#4581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Try this" suggestion includes trailing comments
4 participants
@kmill @leanprover-community-bot @Kha @kim-em