Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid max heartbeat error in completion #5996

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Nov 7, 2024

This now occurs for some large completions downstream of import Mathlib. I'd like to get rid of this whnf call entirely in the future, but this is a decent quick mitigation.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 7, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 7, 2024
@mhuisi mhuisi added this pull request to the merge queue Nov 8, 2024
Merged via the queue into leanprover:master with commit cb40dda Nov 8, 2024
16 checks passed
@kim-em kim-em added the changelog-server Language server, widgets, and IDE extensions label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants