fix: avoid new term info around def bodies#6031
Merged
Kha merged 2 commits intoleanprover:masterfrom Nov 11, 2024
Merged
Conversation
mhuisi
approved these changes
Nov 11, 2024
github-actions
bot
added
the
toolchain-available
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
ghost
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 11, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
This PR fixes a regression with go-to-definition and document highlight misbehaving on tactic blocks. We explicitly avoid creating term info nodes around `by` blocks, which #5338 might accidentally do; as the new info is not relevant for the server, it is instead moved into a custom info. Reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Go-to-def.20for.20tactics.20broken.20on.20v4.2E14.2E0-rc1. (cherry picked from commit 004430b)
Kha
added a commit
that referenced
this pull request
Nov 15, 2024
This PR fixes a regression with go-to-definition and document highlight misbehaving on tactic blocks. We explicitly avoid creating term info nodes around `by` blocks, which #5338 might accidentally do; as the new info is not relevant for the server, it is instead moved into a custom info. Reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Go-to-def.20for.20tactics.20broken.20on.20v4.2E14.2E0-rc1. (cherry picked from commit 004430b)
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR fixes a regression with go-to-definition and document highlight misbehaving on tactic blocks. We explicitly avoid creating term info nodes around `by` blocks, which leanprover#5338 might accidentally do; as the new info is not relevant for the server, it is instead moved into a custom info. Reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Go-to-def.20for.20tactics.20broken.20on.20v4.2E14.2E0-rc1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression with go-to-definition and document highlight misbehaving on tactic blocks.
We explicitly avoid creating term info nodes around
byblocks, which #5338 might accidentally do; as the new info is not relevant for the server, it is instead moved into a custom info.Reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Go-to-def.20for.20tactics.20broken.20on.20v4.2E14.2E0-rc1.