Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bv_decide embedded constraint substitution changes models #6037

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: bv_decide embedded constraint substitution changes models #6037

merged 1 commit into from
Nov 11, 2024

Conversation

hargoniX
Copy link
Contributor

This PR fixes bv_decide's embedded constraint substitution to generate correct counter examples in the corner case where duplicate theorems are in the local context.

@hargoniX hargoniX added the changelog-language Language features, tactics, and metaprograms label Nov 11, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 11, 2024 16:02 Inactive
@hargoniX hargoniX enabled auto-merge November 11, 2024 16:02
@hargoniX hargoniX changed the title fix: embedded constraint substitution changes models fix: bv_decide embedded constraint substitution changes models Nov 11, 2024
@hargoniX hargoniX added this pull request to the merge queue Nov 11, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 11, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 61f7dcb36b43b05903cf02236f85426db6d59365 --onto 456e6d2b791bbc560b304b28a60f35db7072c306. (2024-11-11 16:36:40)

Merged via the queue into master with commit 281c07c Nov 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hargoniX @leanprover-community-bot