Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: review Array operations argument order #6041

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 12, 2024

This PR modifies the order of arguments for higher-order Array functions, preferring to put the Array last (besides positional arguments with defaults). This is more consistent with the List API, and is more flexible, as dot notation allows two different partially applied versions.

@kim-em kim-em requested a review from digama0 as a code owner November 12, 2024 04:34
@kim-em kim-em enabled auto-merge November 12, 2024 04:34
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 12, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3a408e0e54de9a6859a1bd9c53c7adf4d1a28e37 --onto 456e6d2b791bbc560b304b28a60f35db7072c306. (2024-11-12 04:52:00)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 12, 2024 04:54 Inactive
@kim-em kim-em added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit 5e01e62 Nov 12, 2024
15 checks passed
@kim-em kim-em added the changelog-library Library label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants