Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BitVec.[toInt|toFin]_concat and Bool.toInt #6182

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: BitVec.[toInt|toFin]_concat and Bool.toInt #6182

merged 4 commits into from
Dec 4, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Nov 23, 2024 •
edited
Loading

This PR adds BitVec.[toInt|toFin]_concat and moves a couple of theorems into the concat section, as BitVec.msb_concat is needed for the toInt_concat proof.

We also add Bool.toInt.

@tobiasgrosser
Copy link
Contributor Author

changelog-library

@github-actions github-actions bot added the changelog-library Library label Nov 23, 2024
@tobiasgrosser
feat: BitVec.[toInt|toFin]_concat
cb8548e 
This PR adds `BitVec.[toInt|toFin]_concat` and moves a couple of theorems into
the concat section, as `BitVec.msb_concat` is needed for the `toInt_concat`
proof.
@tobiasgrosser tobiasgrosser changed the title feat: BitVec.[toInt|toFin]_concat feat: BitVec.[toInt|toFin]_concat and Bool.toInt Nov 23, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 23, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 23, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ba3f2b3ecf8967410f3498e2835b883601f03967 --onto 6202461a21d2636129cb8950cd9b6549ccf4b185. (2024-11-23 04:16:51)
  • 🟡 Mathlib branch lean-pr-testing-6182 build against this PR was cancelled. (2024-11-29 05:33:41) View Log
  • ✅ Mathlib branch lean-pr-testing-6182 has successfully built against this PR. (2024-11-29 06:27:43) View Log

kim-em
kim-em reviewed Nov 23, 2024
View reviewed changes
src/Init/Data/Bool.lean Outdated Show resolved Hide resolved
@kim-em kim-em added the awaiting-author Waiting for PR author to address issues label Nov 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6182
e2301b3
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6182
b88534c
@tobiasgrosser
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Nov 29, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6182
e67967a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6182
2b60a5c
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 29, 2024
@kim-em kim-em removed the awaiting-review Waiting for someone to review the PR label Dec 4, 2024
@kim-em kim-em added this pull request to the merge queue Dec 4, 2024
Merged via the queue into leanprover:master with commit c518156 Dec 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasgrosser @leanprover-community-bot @kim-em