Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: USize.reduceToNat #6190

Merged
merged 3 commits into from
Nov 29, 2024
Merged

feat: USize.reduceToNat #6190

merged 3 commits into from
Nov 29, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Nov 23, 2024 •
edited
Loading

This PR adds the builtin simproc USize.reduceToNat which reduces the USize.toNat operation on literals less than UInt32.size (i.e., 4294967296).

@tydeu tydeu added the changelog-library Library label Nov 23, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 23, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6190
603b4fd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 23, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6190
1dd4665
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Nov 24, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 24, 2024 •
edited
Loading

Mathlib CI status (docs):

@tydeu tydeu force-pushed the usize-reduceToNat branch from 458f02a to 1fd3490 Compare November 24, 2024 23:06
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
2d87143
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
d92372f
@tydeu tydeu force-pushed the usize-reduceToNat branch from 1fd3490 to b1adefe Compare November 28, 2024 06:59
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
e88e9e2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
cd95195
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
2c1b7b5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
69c956f
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Nov 28, 2024
@tydeu tydeu marked this pull request as ready for review November 28, 2024 20:39
@tydeu tydeu requested a review from leodemoura as a code owner November 28, 2024 20:39
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
9e5e0bf
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
d73be0a
@tydeu tydeu force-pushed the usize-reduceToNat branch from e462b97 to 088c55f Compare November 29, 2024 03:34
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
49a3640
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6190
96c05dc
@kim-em kim-em added this pull request to the merge queue Nov 29, 2024
Merged via the queue into leanprover:master with commit 27cc0c8 Nov 29, 2024
15 checks passed
@tydeu tydeu deleted the usize-reduceToNat branch November 29, 2024 21:48
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@tydeu @JovanGerb
feat: USize.reduceToNat (leanprover#6190)
d7b60b3 
This PR adds the builtin simproc `USize.reduceToNat` which reduces the
`USize.toNat` operation on literals less than `UInt32.size` (i.e.,
`4294967296`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tydeu @leanprover-community-bot @kim-em