Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default parseQuotWithCurrentStage to true in stage 0 #6212

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Nov 25, 2024

Use the default that solves bootstrapping issues in exchange for an insignificant(?) perf overhead

@Kha
Copy link
Member Author

Kha commented Nov 25, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 731ce4c.
There were significant changes against commit 884a9ea:

  Benchmark   Metric         Change
  ============================================
- stdlib      instructions    10.2% (3906.1 σ)
- stdlib      task-clock       6.8%   (53.4 σ)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 25, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 25, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 25, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@Kha
Copy link
Member Author

Kha commented Nov 25, 2024

!bench

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 25, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 25, 2024

Mathlib CI status (docs):

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 0f8f040.
There were significant changes against commit 884a9ea:

  Benchmark                   Metric         Change
  ============================================================
+ bv_decide_inequality.lean   task-clock      -5.8%  (-18.8 σ)
+ bv_decide_inequality.lean   wall-clock      -6.4%  (-11.2 σ)
- stdlib                      instructions    10.2% (5791.1 σ)
- stdlib                      task-clock       7.1%   (61.1 σ)
- stdlib                      wall-clock       4.1%   (23.4 σ)

@Kha Kha marked this pull request as ready for review November 26, 2024 10:28
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2024
@Kha Kha added this pull request to the merge queue Nov 27, 2024
Merged via the queue into leanprover:master with commit 5982a6d Nov 27, 2024
16 checks passed
@Kha Kha deleted the push-kryqquowrruu branch November 27, 2024 15:54
@kim-em kim-em added the changelog-no Do not include this PR in the release changelog label Jan 4, 2025
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
…prover#6212)

Use the default that solves bootstrapping issues in exchange for an
insignificant(?) perf overhead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants