Skip to content

feat: GitHub cloud releases do not clobber prebuilt artifacts#6218

Merged
tydeu merged 1 commit intoleanprover:masterfrom
tydeu:lake/cache-no-clobber
Nov 26, 2024
Merged

feat: GitHub cloud releases do not clobber prebuilt artifacts#6218
tydeu merged 1 commit intoleanprover:masterfrom
tydeu:lake/cache-no-clobber

Conversation

@tydeu
Copy link
Member

@tydeu tydeu commented Nov 26, 2024

This PR makes Lake no longer automatically fetch GitHub cloud releases if the package build directory is already present (mirroring the behavior of the Reservoir cache). This prevents the cache from clobbering existing prebuilt artifacts. Users can still manually fetch the cache and clobber the build directory by running lake build <pkg>:release.

@tydeu tydeu added the changelog-lake Lake label Nov 26, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 26, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Nov 26, 2024
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2024
@ghost ghost added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 26, 2024
@ghost
Copy link

ghost commented Nov 26, 2024

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review November 26, 2024 19:54
@tydeu tydeu added this pull request to the merge queue Nov 26, 2024
Merged via the queue into leanprover:master with commit 3ece36d Nov 26, 2024
@tydeu tydeu deleted the lake/cache-no-clobber branch November 26, 2024 23:41
kim-em pushed a commit that referenced this pull request Nov 27, 2024
This PR makes Lake no longer automatically fetch GitHub cloud releases
if the package build directory is already present (mirroring the
behavior of the Reservoir cache). This prevents the cache from
clobbering existing prebuilt artifacts. Users can still manually fetch
the cache and clobber the build directory by running `lake build
<pkg>:release`.
kim-em pushed a commit that referenced this pull request Nov 29, 2024
This PR makes Lake no longer automatically fetch GitHub cloud releases
if the package build directory is already present (mirroring the
behavior of the Reservoir cache). This prevents the cache from
clobbering existing prebuilt artifacts. Users can still manually fetch
the cache and clobber the build directory by running `lake build
<pkg>:release`.
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
…over#6218)

This PR makes Lake no longer automatically fetch GitHub cloud releases
if the package build directory is already present (mirroring the
behavior of the Reservoir cache). This prevents the cache from
clobbering existing prebuilt artifacts. Users can still manually fetch
the cache and clobber the build directory by running `lake build
<pkg>:release`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant