-
Notifications
You must be signed in to change notification settings - Fork 594
feat: upstream ToLevel
from mathlib
#6285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bc4b979
Upstream ToLevel
alexkeizer 57719f5
fix: use ToLevel in universe polymorphic ToExpr instances
alexkeizer c07b231
update test to account for changed `ToExpr List` instance
alexkeizer 8569c9c
Apply suggestions from code review
alexkeizer c4fa866
simplify ToLevel.univ
alexkeizer ba8ca52
remove explicit universe declarations
alexkeizer 7e7221e
use `toLevel.{u}` rather than name the instance
alexkeizer 9f27083
Merge remote-tracking branch 'origin/master' into upstream-tolevel
tobiasgrosser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/- | ||
Copyright (c) 2023 Kyle Miller. All rights reserved. | ||
Released under Apache 2.0 license as described in the file LICENSE. | ||
Authors: Kyle Miller, Alex Keizer | ||
-/ | ||
prelude | ||
import Lean.Expr | ||
|
||
/-! # `ToLevel` class | ||
alexkeizer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This module defines `Lean.ToLevel`, which is the `Lean.Level` analogue to `Lean.ToExpr`. | ||
-/ | ||
|
||
namespace Lean | ||
|
||
universe w | ||
alexkeizer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/-- A class to create `Level` expressions that denote particular universe levels in Lean. | ||
`Lean.ToLevel.toLevel.{u}` evaluates to a `Lean.Level` term representing `u` -/ | ||
class ToLevel.{u} : Type where | ||
/-- A `Level` that represents the universe level `u`. -/ | ||
toLevel : Level | ||
/-- The universe itself. This is only here to avoid the "unused universe parameter" error. | ||
We'll remove this field once https://github.com/leanprover/lean4/issues/2116 gets fixed. | ||
-/ | ||
alexkeizer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
univ : ∃ x, x = PUnit.unit.{u} := ⟨_, rfl⟩ | ||
alexkeizer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
export ToLevel (toLevel) | ||
|
||
instance : ToLevel.{0} where | ||
toLevel := .zero | ||
|
||
universe u v | ||
|
||
instance [ToLevel.{u}] : ToLevel.{u+1} where | ||
toLevel := .succ toLevel.{u} | ||
|
||
/-- `ToLevel` for `max u v`. This is not an instance since it causes divergence. -/ | ||
def ToLevel.max [ToLevel.{u}] [ToLevel.{v}] : ToLevel.{max u v} where | ||
toLevel := .max toLevel.{u} toLevel.{v} | ||
|
||
/-- `ToLevel` for `imax u v`. This is not an instance since it causes divergence. -/ | ||
def ToLevel.imax [ToLevel.{u}] [ToLevel.{v}] : ToLevel.{imax u v} where | ||
toLevel := .imax toLevel.{u} toLevel.{v} | ||
|
||
end Lean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.