Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: E-matching module for grind #6488

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix: E-matching module for grind #6488

merged 4 commits into from
Dec 31, 2024

Conversation

leodemoura
Copy link
Member

This PR fixes and refactors the E-matching module for the (WIP) grind tactic.

Next step: top-level search procedure for grind.

@leodemoura
refactor: avoid internalizing e-match new instances in the `EMatch.le…
67fb33e 
…an` module.

Reason: It does not use the correct monad. We want to preprocess the
new instances before internalizing them, and preprocessing may trigger
the creation of new goals.
@leodemoura
chore: move configuration getters to Types.lean
1e66ead
@leodemoura
feat: cleanup enode and parents map
f441a55
@leodemoura
feat: add PreInstanceSet
9c25a94
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Dec 31, 2024
@leodemoura leodemoura enabled auto-merge December 31, 2024 19:53
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc December 31, 2024 20:00 Inactive
@leodemoura leodemoura added this pull request to the merge queue Dec 31, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 31, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8899c7ed8c2a6d364b88b9457fef32866a6e7a74 --onto 2c87905d77b707c3283c1de759fd63269ac386a1. (2024-12-31 20:11:21)

Merged via the queue into master with commit 5ba4761 Dec 31, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot