Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theorem instantiation in grind #6492

Merged
merged 4 commits into from
Jan 1, 2025
Merged

fix: theorem instantiation in grind #6492

merged 4 commits into from
Jan 1, 2025

Conversation

leodemoura
Copy link
Member

@leodemoura leodemoura commented Jan 1, 2025

This PR fixes a bug in the theorem instantiation procedure in the (WIP) grind tactic. For example, it was missing the following instance in one of the tests:

[grind.ematch.instance] Array.get_set_ne: ∀ (hj : i < bs.size), j ≠ i → (bs.set j w ⋯)[i] = bs[i]

This PR also renames the grind base monad to GrindCoreM.

@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 1, 2025
@leodemoura leodemoura enabled auto-merge January 1, 2025 17:07
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 1, 2025 17:15 Inactive
@leodemoura leodemoura disabled auto-merge January 1, 2025 17:20
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 1, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-01-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2025-01-01 17:25:21)

@leodemoura leodemoura enabled auto-merge January 1, 2025 17:43
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 1, 2025 17:51 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 1, 2025
Merged via the queue into master with commit fedaf85 Jan 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants