Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing case in checkParents #6508

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: missing case in checkParents #6508

merged 1 commit into from
Jan 2, 2025

Conversation

leodemoura
Copy link
Member

This PR fixes a bug in the sanity checkers for the grind tactic. See the new test for an example of a case where it was panicking.

@leodemoura
fix: missing case in checkParents
108bf11 
This PR fixes a bug in the sanity checkers for the `grind` tactic.
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 2, 2025
@leodemoura leodemoura enabled auto-merge January 2, 2025 15:50
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 2, 2025 15:59 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 2, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 2, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 092449adb8488a8fcbbebf9fdfcec38deef1eb81 --onto 8d9d81453bd28aa9799e6bf2ad52def1d75549cb. (2025-01-02 16:11:09)

github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2025
@leodemoura
fix: missing case in checkParents (#6508)
3cba171 
This PR fixes a bug in the sanity checkers for the `grind` tactic. See
the new test for an example of a case where it was panicking.
Merged via the queue into master with commit 3cba171 Jan 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot