Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve grind failure message #6633

Merged
merged 6 commits into from
Jan 14, 2025
Merged

feat: improve grind failure message #6633

merged 6 commits into from
Jan 14, 2025

Conversation

leodemoura
Copy link
Member

This PR improves the failure message produced by the grind tactic. We now include information about asserted facts, propositions that are known to be true and false, and equivalence classes.

@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 14, 2025
@leodemoura leodemoura requested a review from kim-em as a code owner January 14, 2025 00:36
@leodemoura leodemoura enabled auto-merge January 14, 2025 00:36
@leodemoura leodemoura disabled auto-merge January 14, 2025 00:38
@leodemoura leodemoura enabled auto-merge January 14, 2025 00:47
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 14, 2025 01:01 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 14, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 14, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 85560da3e484d08a507683e3c7d2a49e3790df95 --onto d2c4471cfa4611977bf4927b5cd849df1a4272b7. (2025-01-14 01:14:29)

Merged via the queue into master with commit f57745e Jan 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot