Skip to content

perf: improve bv_decide preprocessing based on Bitwuzla optimisations #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Jan 14, 2025

This PR implements several optimisation tricks from Bitwuzla's preprocessing passes into the Lean equivalent in bv_decide. Note that these changes are mostly geared towards large proof states as for example seen in SMT-Lib.

@hargoniX hargoniX added the changelog-language Language features, tactics, and metaprograms label Jan 14, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 14, 2025 13:26 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 14, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9dbe5e6f9ce6bc686541218f62ff6b8063dfc4dc --onto e9bd9807ef7a983365df9ac55d35040d0b2d5ef2. (2025-01-14 13:40:29)

@hargoniX hargoniX force-pushed the hbv/bv_decide_preproc_perf branch 2 times, most recently from 8827e8e to b140468 Compare January 14, 2025 21:46
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 14, 2025 21:54 Inactive
@hargoniX hargoniX force-pushed the hbv/bv_decide_preproc_perf branch from b140468 to 98b9eb9 Compare January 15, 2025 09:21
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 15, 2025 09:34 Inactive
@hargoniX
Copy link
Contributor Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 15, 2025 10:03 Inactive
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 2e8335f.
There were no significant changes against commit 9dbe5e6.

@hargoniX hargoniX added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit a1ef26b Jan 15, 2025
17 checks passed
@hargoniX hargoniX deleted the hbv/bv_decide_preproc_perf branch January 15, 2025 13:45
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
…leanprover#6641)

This PR implements several optimisation tricks from Bitwuzla's
preprocessing passes into the Lean equivalent in `bv_decide`. Note that
these changes are mostly geared towards large proof states as for
example seen in SMT-Lib.
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
…leanprover#6641)

This PR implements several optimisation tricks from Bitwuzla's
preprocessing passes into the Lean equivalent in `bv_decide`. Note that
these changes are mostly geared towards large proof states as for
example seen in SMT-Lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants