Skip to content

feat: Constructions for splitting and merging vectors of bitvectors#7754

Open
javra wants to merge 10 commits intoleanprover:masterfrom
javra:bitvec_split
Open

feat: Constructions for splitting and merging vectors of bitvectors#7754
javra wants to merge 10 commits intoleanprover:masterfrom
javra:bitvec_split

Conversation

@javra
Copy link
Contributor

@javra javra commented Mar 31, 2025

This PR provides functions to merge and split vectors of bitvectors, taking up the abandoned #3727.

@javra javra requested a review from kim-em as a code owner March 31, 2025 11:53
@javra
Copy link
Contributor Author

javra commented Mar 31, 2025

WIP

@github-actions github-actions bot added the WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. label Mar 31, 2025
@javra
Copy link
Contributor Author

javra commented Mar 31, 2025

changelog-library

@github-actions github-actions bot added changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Mar 31, 2025
@ghost
Copy link

ghost commented Mar 31, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 797b0e2c621d1c9513fefc98429c80f632ea8328 --onto 2edfe2e9cffd55e3c79291628ae091b942291ec9. You can force Mathlib CI using the force-mathlib-ci label. (2025-03-31 12:20:56)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 797b0e2c621d1c9513fefc98429c80f632ea8328 --onto 911ea07a73733650eefa5240652404856bdcceb7. You can force Mathlib CI using the force-mathlib-ci label. (2025-04-02 08:19:02)

Copy link
Contributor

@bollu bollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo suggested changes!

Co-authored-by: Siddharth <siddu.druid@gmail.com>
@leanprover-bot leanprover-bot added the P-medium We may work on this issue if we find the time label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-library Library P-medium We may work on this issue if we find the time toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants