Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

prototype option to run rspec with ruby warnings enabled #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ariccio-learn-co-alternate

I've added the option to run RSpec with Ruby warnings enabled. Personally, I'd love to see this enabled by default - I've found sketchy things in some of the specs for the labs I've been working on - but in the meantime, this does what I need it to do, and shouldn't be too controversial.

What do the maintainers think about running RSpec with warnings enabled by default?

@ariccio-learn-co-alternate
Copy link
Author

@aviflombaum @gj

loud, annoying, duck-like, voice
nag

@ariccio-learn-co-alternate
Copy link
Author

lmao I think I'mma be done with the entire curriculum before this gets merged...

@ariccio
Copy link

ariccio commented Jul 16, 2019

@realAndrewCohn

@notnotdrew
Copy link
Member

notnotdrew commented Aug 2, 2019

Hey @ariccio! Thanks for opening this up.

Running this by default is not likely something we can introduce. The learn test command is used by a wide range of our students, so while it may be useful for someone further along, it's likely to cause confusion for someone on their first lab.

That said, introducing the optional argument is potentially something we can do. I've added this PR to our internal planning for the learn-co gem suite. When we prepare the next release, we can take a closer look. That will likely be sometime within the next few months.

Sorry for the delay! We really love to see participation in our OS work from students, so thanks again, and we'll keep you updated on this.

@ariccio-learn-co-alternate
Copy link
Author

Yeah, I bet it would cause some confusion, since some of the labs are themselves buggy 😆

On a serious note, I did spend hours in that first week debugging things that would've been caught by the warnings, so maybe it'd make new students more productive?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants