Skip to content

Use target-specific include dirs #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aobolensk
Copy link
Member

Summary

  • drop global include_directories from the top CMakeLists
  • expose include paths directly for core_module_lib and its tests
  • set include directories in helper functions for tests and library implementations

Testing

  • cmake -S . -B build (fails: No download info given for 'ppc_json')

https://chatgpt.com/codex/tasks/task_e_68594d796530832f9d302f10d42016e4

@@ -47,9 +47,6 @@ include(cmake/gtest.cmake)
############################## Headers ##############################

message( STATUS "PPC step: Setup headers" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all info about headers here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants