Skip to content

Conversation

@AllanOXDi
Copy link
Member

Summary

Removes the PaginatedListContainerWithBackend.vue component and cleans up places it is used.
Closes #13844

References

#13844

Reviewer guidance

Does the change look okay ? Is it causing regression ?

@github-actions github-actions bot added APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium labels Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcenov the main place I think regressions might lurk are in the DownloadList - otherwise will just need to test the UserTable in Facility.

@AllanOXDi code changes lgtm - just a note about a maybe not needed tag.

/>
</div>
</div>
<template>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this tag is unnecessary now?

@pcenov pcenov self-requested a review November 14, 2025 14:56
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi and @nucleogenesis - LGTM!

@AllanOXDi AllanOXDi merged commit 6fb4a8e into learningequality:develop Nov 18, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Clean-up]: PaginatedListContainerWithBackend.vue

3 participants