Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audiences + Send notifications #36

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

danielneis
Copy link
Contributor

This pull request has the code from #33 and #35.

@zpottie
Copy link
Contributor

zpottie commented Oct 8, 2021

Does this make #33 & #35 void? This completely replaces those two? So I can delete/close those?

@danielneis
Copy link
Contributor Author

Yes! You can delete those two and use this one.
I just made a different branch in case you would like to take a look at them separately.

if the block is in a course, it will consider users with any
of the selected roles assigned in the course or in any sub contexts.

if the block is in a category, it will consider users with any
of the selected roles assigned in the category or in any sub contexts.

if the block is in the dashboard, it will consider users with any
of the selected roles assigned in any context.

if the block is in the system context, it will consider users with any
of the selected roles assigned in any context.
@danielneis danielneis force-pushed the audiences+sendnotification branch from e6c1462 to 420c135 Compare October 14, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants