require externallib for moodle 401

learnweb · May 17, 2024 · c35f6f4 · c35f6f4
1 parent f657fe5
commit c35f6f4
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/classes/external.php b/classes/external.php
@@ -47,6 +47,10 @@ class external extends external_api {
      * @return external_function_parameters
      */
     public static function record_usersettings_parameters(): external_function_parameters {
+        global $CFG;
+        if ($CFG->branch < 402) {
+            require_once("$CFG->libdir/externallib.php");
+        }
         return new external_function_parameters(
             [
                 'userid' => new external_value(PARAM_INT, 'the user id'),
@@ -59,6 +63,8 @@ public static function record_usersettings_parameters(): external_function_param
         );
     }
 
+    public static function record_usersettings_params(): {}
+
     /**
      * Return the result of the record_usersettings function
      * @return external_value
@@ -80,18 +86,13 @@ public static function record_usersettings_returns(): external_value {
      */
     public static function record_usersettings($userid, $timefilterpast, $timefilterfuture,
                                                $basicletter, $completionletter, $postletter): bool {
-        global $DB, $CFG;
+        global $DB;
 
         // Parameter validation.
-        if ($CFG->branch >= 402) {
-            $params = self::validate_parameters(self::record_usersettings_parameters(), [
-                'userid' => $userid, 'timefilterpast' => $timefilterpast, 'timefilterfuture' => $timefilterfuture,
-                'basicletter' => $basicletter, 'completionletter' => $completionletter, 'postletter' => $postletter,
-            ]);
-        } else {
-            $params = ['userid' => $userid, 'timefilterpast' => $timefilterpast, 'timefilterfuture' => $timefilterfuture,
-                'basicletter' => $basicletter, 'completionletter' => $completionletter, 'postletter' => $postletter, ];
-        }
+        $params = self::validate_parameters(self::record_usersettings_parameters(), [
+            'userid' => $userid, 'timefilterpast' => $timefilterpast, 'timefilterfuture' => $timefilterfuture,
+            'basicletter' => $basicletter, 'completionletter' => $completionletter, 'postletter' => $postletter,
+        ]);
 
         // Check if the user already has a record in the database.
         if ($records = $DB->get_records('block_townsquare_preferences', ['userid' => $userid])) {