Skip to content

Conversation

@sh-csg
Copy link
Contributor

@sh-csg sh-csg commented Nov 23, 2025

🔀 Purpose of this PR:

  • Fixes a bug

📝 Description:

If you have enabled marking as helpful and as a solution at the same time, the icons are displayed side by side at the post and are not aligned to the upvote / downvote icons above them. The PR fixes this.


📋 Checklist

Please confirm the following (check all that apply):

  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.

Copy link
Collaborator

@TamaroWalter TamaroWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it's better that the icons are visually placed differently than the up/downvotes, as they aren't clickable actions but "information" only. And for small posts the icons take up less space if they are placed horizontically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants