extracting the from_ptr static method

src/account.rs

@@ -88,7 +88,7 @@ impl Account {
     /// i.e. "Assets:Cash"
     pub fn find_account(&self, name: &str) -> Option<&Account> {
         if let Some(ptr) = self.find_or_create(name, false) {
-            let acct = self.get_account(ptr);
+            let acct = Account::from_ptr(ptr);
             return Some(acct);
         } else {
             return None;
@@ -138,7 +138,7 @@ impl Account {
         Some(account)
     }
 
-    pub fn get_account(&self, acct_ptr: *const Account) -> &Account {
+    pub fn from_ptr<'a>(acct_ptr: *const Account) -> &'a Account {
         unsafe { &*acct_ptr }
     }
 

src/amount.rs

@@ -22,7 +22,7 @@ impl Amount {
         Self {
             quantity,
             commodity: if commodity.is_some() {
-                commodity.unwrap() as *const Commodity
+                commodity.unwrap()
             } else {
                 std::ptr::null()
             },

src/history.rs

@@ -266,9 +266,9 @@ pub struct Price {
 }
 
 impl Price {
-    pub fn new(commodity: &Commodity, datetime: NaiveDateTime, cost: Amount) -> Self {
+    pub fn new(commodity: *const Commodity, datetime: NaiveDateTime, cost: Amount) -> Self {
         Self {
-            commodity: commodity as *const Commodity,
+            commodity,
             datetime,
             price: cost,
         }

src/pool.rs

@@ -188,7 +188,7 @@ impl CommodityPool {
             // self.add_price(amount.commodity_index.unwrap(), moment, per_unit_cost);
             // Instead, return the new price and have the caller store it.
             new_price = Some(Price::new(
-                amount.get_commodity().unwrap(),
+                amount.commodity,
                 moment,
                 per_unit_cost,
             ));