Added Favicon and Assets Folder #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added logo
I added the favicon to the tab as well as added it on the top left of the page. I also created an assets folder for the images and audio used in our site.
ignore .DS_Store
lee2sman
reviewed
Nov 17, 2021
Owner
lee2sman
left a comment
lee2sman
left a comment
There was a problem hiding this comment.
I'm almost ready to merge. Can you move the height and width if needed to the stylesheet so we are only looking in one place?
updated the style of the logo to the css file
Author
|
fixed the height and width by putting them into the css file |
Owner
|
Can you resolve conflicts? |
updated the html and css conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added favicon and assets folder