Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options and setup instructions #3

Closed

Conversation

kevin51jiang
Copy link

Love this template! Simple enough to use, and the design is nice as well.

I wanted to use it for myself, so I made a few changes that make it easy for other people to change the configuration. There should be no actual text changes, except where in a few spots I changed it from (c) 2022 to (c) ${getCurrentYear()}.

I also added setup instructions so other people can quickly get setup.

@leebyron
Copy link
Owner

This is great!

Small suggestions:

  • copyright should be from the time stamp of the source markdown doc being generated
  • Config is great, but rather than putting in first/last, instead allow full configuration of the title text and other content fields
  • would you be okay including a designed by Lee Byron link in the footer that links back to the original? It could help others find this tool

@kevin51jiang
Copy link
Author

  1. As far as I can tell, for the individual files the copyright stays at when the markdown doc was generated, while only the site's copyright is $CURRENT_YEAR. Do you have a specific area you saw that needed changing?
  2. I assume people who would care enough would be able to change this themselves? I personally find the current defaults pretty decent and applicable
  3. Yeah definitely, gotta give the creator credit lol

@kevin51jiang
Copy link
Author

Hey @leebyron just pinging to see if you're still interested :)

@leebyron leebyron mentioned this pull request Jan 2, 2024
@leebyron leebyron closed this in #5 Jan 2, 2024
@leebyron
Copy link
Owner

leebyron commented Jan 2, 2024

Sorry for letting this sit for so long, but I appreciate your support and help! I tried to amend to this branch but hit some snags so I pulled your commits directly over to #5 so I could rebase and amend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants