Fix dropping of items and digging after letting go from scale/hangle #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119.
Dropping items when letting go from scaling was just the missing
break
.The hangle case is a bit more complicated because the drop command is initiated by checking
LastComDownDouble
, which is set based onLastCom
. So by clearingLastCom
when letting go, the problem goes away. Dropping items after landing as before is still possible by pressing Down-Down-Throw again while in the air instead of just Down-Throw as before.I'm not sure if the
if
in line 3548 is really necessary, becauseObjectComLetGo
can only return false for an object which can scale/hangle but has no "Jump" action, so it can not let go. At that point, we can as well leaveLastCom
alone, I guess, maybe the object wants to do something special with it...Weapons were not tested, and I'm unsure if there are any weird interactions with scripts or other custom content.