Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch channelinfo #88

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Patch channelinfo #88

merged 2 commits into from
Jan 22, 2025

Conversation

theHenks
Copy link
Collaborator

extended kwarg is used for cashing of channelinfo to prevent long loading times. This was a bug since before the user hat to manually reset the cache by creating a new LegendData object if the extended kwarg was used after the function was called witout before.

Minor bug fixes in column layout

@theHenks theHenks requested a review from fhagemann January 22, 2025 14:09
@theHenks theHenks self-assigned this Jan 22, 2025
@theHenks theHenks added the bug Something isn't working label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.08%. Comparing base (a678b6b) to head (f5dbad1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   42.07%   42.08%   +0.01%     
==========================================
  Files          26       26              
  Lines        1975     1972       -3     
==========================================
- Hits          831      830       -1     
+ Misses       1144     1142       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

At critical points, we used to just delete the _cached_channelinfo, if the extended channelinfo was needed. This is not needed anymore
Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some workarounds to delete the cache if the extended channelinfo was needed but the reduced channelinfo was already cached. We can probably delete them now. The tests will reveal whether this works or not.

@theHenks
Copy link
Collaborator Author

Tests look fine. Go ahead and merge if you are happy

@fhagemann fhagemann merged commit a660e56 into main Jan 22, 2025
11 checks passed
@fhagemann fhagemann deleted the patch_channelinfo branch January 22, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants