Skip to content

Allow for in-place reading + decompression of ArrayOfEqualSizedArrays if object buffer is provided #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2023
Merged

Allow for in-place reading + decompression of ArrayOfEqualSizedArrays if object buffer is provided #23

merged 4 commits into from
Nov 6, 2023

Conversation

gipert
Copy link
Member

@gipert gipert commented Oct 28, 2023 •
edited
Loading

To do: cross-check object buffer (with start) functionality

@gipert gipert added the compression Waveform Compression label Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/lgdo/compression/generic.py 74.19% <50.00%> (ø)
src/lgdo/compression/radware.py 24.82% <66.66%> (ø)
src/lgdo/compression/varlen.py 49.60% <50.00%> (ø)
src/lgdo/lh5_store.py 82.55% <41.66%> (-0.73%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@gipert gipert requested a review from jasondet October 30, 2023 16:21
@gipert gipert marked this pull request as ready for review November 6, 2023 18:28
@gipert gipert merged commit 6901bf3 into main Nov 6, 2023
@gipert gipert deleted the compression branch November 6, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondet jasondet Awaiting requested review from jasondet

Assignees
No one assigned
Labels
compression Waveform Compression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gipert