feat(vnpay): 🔧 refactor for readable and add tests #19
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request refactors the VNPay module for improved readability and maintainability. Key changes include modularizing the payment URL creation and secure hash calculation into separate utility functions, enhancing date handling functions, and updating tests accordingly. Additionally, the jest configuration was updated to set the timezone to UTC and enforce a minimum coverage threshold. The console logger was also enhanced to support different console methods. File-Level Changes
Tips
|
WalkthroughThe recent changes enhance the configuration and functionality of the project, introducing improvements in feedback tone guidance, file ignoring during linting and publishing processes, and significant updates to payment handling utilities. Notable additions include a clear professional tone in feedback, new utility functions for payment processing, and comprehensive testing for these functionalities, all aimed at improving code quality and maintainability. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PaymentProcessor
participant PaymentUtil
participant Logger
User->>PaymentProcessor: Initiate Payment
PaymentProcessor->>PaymentUtil: Build Payment URL
PaymentUtil-->>PaymentProcessor: Return Payment URL
PaymentProcessor->>Logger: Log Payment Initiation
Logger-->>PaymentProcessor: Acknowledge Log
PaymentProcessor->>User: Confirm Payment Processing
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lehuygiang28 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| /** | ||
| * Multiply by 100 to follow VNPay standard, see docs for more detail | ||
| */ | ||
| vnp_Amount: data.vnp_Amount * 100, |
There was a problem hiding this comment.
issue (bug_risk): Potential issue with undefined data.vnp_Amount.
If data.vnp_Amount is undefined, this line will result in NaN. Consider adding a check or default value.
|
|
||
| redirectUrl.searchParams.append(key, value.toString()); | ||
| }); | ||
| const redirectUrl = createPaymentUrl(this.globalDefaultConfig, dataToBuild); |
There was a problem hiding this comment.
issue: Potential issue with createPaymentUrl function.
Ensure that createPaymentUrl handles all edge cases, such as missing or malformed URLs, to avoid runtime errors.
| @@ -147,7 +147,7 @@ describe('buildPaymentUrl', () => { | |||
| ...baseInput, | |||
| }; | |||
| delete input.vnp_CreateDate; | |||
| const currentTime = dateFormat(new Date()); | |||
| const currentTime = dateFormat(getDateInGMT7()); | |||
There was a problem hiding this comment.
suggestion (testing): Add test for missing vnp_CreateDate edge case
Consider adding a test case to verify the behavior when vnp_CreateDate is missing. This will ensure that the getDateInGMT7 function is correctly setting the date.
| const currentTime = dateFormat(getDateInGMT7()); | |
| test('should handle missing vnp_CreateDate by using current time in GMT+7', () => { | |
| const input = { /* your input object without vnp_CreateDate */ }; | |
| const currentTime = dateFormat(getDateInGMT7()); | |
| const result = vnpay.buildPaymentUrl(input); | |
| expect(result).toContain(currentTime); | |
| }); |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range comments (1)
src/utils/common.ts (1)
Line range hint
45-70: Remove the redundant case clause.The
case 'local':clause is redundant because thedefaultclause handles it.- case 'local':Tools
Biome
[error] 68-69: Useless case clause.
because the default clause is present:
Unsafe fix: Remove the useless case.
(lint/complexity/noUselessSwitchCase)
[error] 55-55: Use Number.parseInt instead of the equivalent global.
ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.parseInt instead.(lint/style/useNumberNamespace)
[error] 56-56: Use Number.parseInt instead of the equivalent global.
ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.parseInt instead.(lint/style/useNumberNamespace)
Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Files selected for processing (17)
- .coderabbit.yaml (1 hunks)
- .eslintignore (1 hunks)
- .gitignore (1 hunks)
- .npmignore (1 hunks)
- .prettierignore (1 hunks)
- jest.config.ts (1 hunks)
- package.json (1 hunks)
- src/utils/common.ts (3 hunks)
- src/utils/index.ts (1 hunks)
- src/utils/logger.ts (2 hunks)
- src/utils/payment.util.ts (1 hunks)
- src/vnpay.ts (5 hunks)
- test/build-payment-url.test.ts (2 hunks)
- test/utils/common.test.ts (1 hunks)
- test/utils/logger.test.ts (1 hunks)
- test/utils/payment-util.test.ts (1 hunks)
- test/verify-return-url.test.ts (1 hunks)
Additional context used
Path-based instructions (11)
src/utils/index.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.jest.config.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.src/utils/logger.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.src/utils/payment.util.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.test/utils/logger.test.ts (2)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Pattern
test/**/*: Review the test files to ensure they cover all the relevant use cases and edge cases of the codebase. Check for proper test coverage, assertions, and error handling. Ensure that the tests are well-organized, easy to read, and provide meaningful feedback. Highlight any missing or redundant tests and suggest improvements to enhance the overall quality of the test suite.test/utils/payment-util.test.ts (2)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Pattern
test/**/*: Review the test files to ensure they cover all the relevant use cases and edge cases of the codebase. Check for proper test coverage, assertions, and error handling. Ensure that the tests are well-organized, easy to read, and provide meaningful feedback. Highlight any missing or redundant tests and suggest improvements to enhance the overall quality of the test suite.src/utils/common.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.test/utils/common.test.ts (2)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Pattern
test/**/*: Review the test files to ensure they cover all the relevant use cases and edge cases of the codebase. Check for proper test coverage, assertions, and error handling. Ensure that the tests are well-organized, easy to read, and provide meaningful feedback. Highlight any missing or redundant tests and suggest improvements to enhance the overall quality of the test suite.test/verify-return-url.test.ts (2)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Pattern
test/**/*: Review the test files to ensure they cover all the relevant use cases and edge cases of the codebase. Check for proper test coverage, assertions, and error handling. Ensure that the tests are well-organized, easy to read, and provide meaningful feedback. Highlight any missing or redundant tests and suggest improvements to enhance the overall quality of the test suite.test/build-payment-url.test.ts (2)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Pattern
test/**/*: Review the test files to ensure they cover all the relevant use cases and edge cases of the codebase. Check for proper test coverage, assertions, and error handling. Ensure that the tests are well-organized, easy to read, and provide meaningful feedback. Highlight any missing or redundant tests and suggest improvements to enhance the overall quality of the test suite.src/vnpay.ts (1)
Pattern
**/*.ts: Review the TypeScript code of the NPM package to ensure it adheres to the principles of awesome and clean code. This includes proper use of functions, classes, modules. Also, ensure the code follows best practices for package development, such as clear and concise documentation, proper error handling, and efficient data structures and algorithms. The code should also conform to the ESLint rules configured in the codebase. Highlight any deviations and suggest appropriate corrections. Using design patterns that promote code reusability and readability is encouraged.
Biome
test/utils/logger.test.ts
[error] 38-38: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
[error] 52-52: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
[error] 64-64: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
src/utils/common.ts
[error] 68-69: Useless case clause.
because the default clause is present:
Unsafe fix: Remove the useless case.
(lint/complexity/noUselessSwitchCase)
Additional comments not posted (53)
.gitignore (2)
4-4: Verify the inclusion of the.envfile.Including the
.envfile in version control can expose sensitive information. Ensure that this change is intentional and that the.envfile does not contain sensitive data.
5-5: Good practice: Ignoring thecoverage/directory.Adding the
coverage/directory to.gitignoreis a good practice to avoid committing generated test coverage reports.src/utils/index.ts (1)
3-3: LGTM!Adding the export for
payment.utilenhances modularity and usability..npmignore (1)
6-6: Good practice: Ignoring thecoverage/directory.Adding the
coverage/directory to.npmignoreis a good practice to avoid including generated test coverage reports in the published package..prettierignore (1)
4-4: LGTM! Excludingcoverage/from Prettier checks is a good practice.This change ensures that generated coverage reports are not unnecessarily formatted by Prettier.
.eslintignore (1)
4-4: LGTM! Excludingcoverage/from ESLint checks is a good practice.This change ensures that generated coverage reports are not unnecessarily linted by ESLint.
jest.config.ts (2)
1-1: Setting the timezone to 'UTC' for consistent testing.This change ensures that all tests run in the 'UTC' timezone, providing consistent date and time handling across tests.
6-10: Enforcing a minimum coverage threshold of 80%.This change improves the reliability and maintainability of the codebase by ensuring that at least 80% of the lines of code are tested.
src/utils/logger.ts (2)
1-1: LGTM! Node.js-specific import forfsmodule.The change aligns with modern JavaScript practices.
17-20: LGTM! Enhanced flexibility inconsoleLoggerfunction.The additional
symbolparameter allows specifying the console method, improving flexibility and ensuring type safety.package.json (1)
19-19: LGTM! Added Jest coverage reporting script.The new script command
"test:cov": "jest --coverage"improves the testing workflow by providing an easy way to check code coverage.src/utils/payment.util.ts (4)
6-18: LGTM! Efficiently builds URL search parameters.The function sorts entries, skips empty values, and sets search parameters correctly.
20-34: LGTM! Creates payment URL efficiently.The function resolves the URL string, builds search parameters, and sets them correctly.
36-43: LGTM! Calculates secure hash efficiently.The function uses the
hashutility to calculate the hash correctly.
45-53: LGTM! Verifies secure hash efficiently.The function uses the
calculateSecureHashutility to calculate the hash and compares it correctly..coderabbit.yaml (1)
4-4: Approved: Addition of tone instructions.The addition of
tone_instructionsenhances the configuration by providing clear guidelines for feedback tone.test/utils/logger.test.ts (6)
11-13: Approved: Test case for ignore logger.The test case correctly verifies that
ignoreLoggerreturns undefined.
15-20: Approved: Test case for logging data to console.The test case correctly verifies that
consoleLoggerlogs data to the console usingjest.spyOn.
22-27: Approved: Test case for logging data to console with specific symbol.The test case correctly verifies that
consoleLoggerlogs data to the console with a specific symbol usingjest.spyOn.
29-41: Approved with suggestion: Test case for logging data to file.The test case correctly verifies that
fileLoggerlogs data to a file. However, consider using template literals for string concatenation.- expect(appendFileMock).toHaveBeenCalledWith( - filePath, - JSON.stringify(data) + '\n', - expect.any(Function), - ); + expect(appendFileMock).toHaveBeenCalledWith( + filePath, + `${JSON.stringify(data)}\n`, + expect.any(Function), + );Tools
Biome
[error] 38-38: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
43-54: Approved with suggestion: Test case for handling file write error.The test case correctly verifies that
fileLoggerhandles file write errors with a callback. However, consider using template literals for string concatenation.- expect(appendFileMock).toHaveBeenCalledWith(filePath, data + '\n', expect.any(Function)); + expect(appendFileMock).toHaveBeenCalledWith(filePath, `${data}\n`, expect.any(Function));Tools
Biome
[error] 52-52: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
56-65: Approved with suggestion: Test case for handling file write error without callback.The test case correctly verifies that
fileLoggerhandles file write errors without a callback. However, consider using template literals for string concatenation.- expect(() => fileLogger(data, filePath)).toThrowError(error); - expect(appendFileMock).toHaveBeenCalledWith(filePath, data + '\n', expect.any(Function)); + expect(() => fileLogger(data, filePath)).toThrowError(error); + expect(appendFileMock).toHaveBeenCalledWith(filePath, `${data}\n`, expect.any(Function));Tools
Biome
[error] 64-64: Template literals are preferred over string concatenation.
Unsafe fix: Use a template literal.
(lint/style/useTemplate)
test/utils/payment-util.test.ts (6)
12-22: Approved: Test case for building search params from data.The test case correctly verifies that
buildPaymentUrlSearchParamsbuilds search parameters from data.
23-31: Approved: Test case for skipping empty value.The test case correctly verifies that
buildPaymentUrlSearchParamsskips empty values.
35-49: Approved: Test case for creating payment URL from config and data.The test case correctly verifies that
createPaymentUrlcreates a payment URL from config and data.
51-62: Approved: Test case for creating a default payment URL.The test case correctly verifies that
createPaymentUrlcreates a default payment URL.
65-73: Approved: Test case for calculating secure hash from data.The test case correctly verifies that
calculateSecureHashcalculates the secure hash from data.
77-86: Approved: Test case for verifying secure hash.The test case correctly verifies that
verifySecureHashverifies the secure hash.src/utils/common.ts (1)
6-9: LGTM!The changes to
getDateInGMT7improve its flexibility by allowing an optional date parameter. The implementation usingmoment-timezoneis correct.test/utils/common.test.ts (8)
20-25: LGTM!The test case correctly verifies the functionality of
getDateInGMT7.
28-33: LGTM!The test case correctly verifies the functionality of
dateFormat.
36-47: LGTM!The test cases correctly verify the functionality of
parseDate.
50-59: LGTM!The test cases correctly verify the functionality of
isValidVnpayDateFormat.
62-73: LGTM!The test cases correctly verify the functionality of
generateRandomString.
76-94: LGTM!The test cases correctly verify the functionality of
getResponseByStatusCode.
97-114: LGTM!The test case correctly verifies the functionality of
resolveUrlString.
117-126: LGTM!The test case correctly verifies the functionality of
hash.test/verify-return-url.test.ts (9)
39-72: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlwith valid input.
74-94: LGTM!The parameterized test cases correctly verify the functionality of
verifyReturnUrlwith different amounts.
96-106: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor a success result.
109-127: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor a failed result.
130-147: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor a failed result with an invalid secure hash.
149-152: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor an invalid amount error.
154-163: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor amount conversion.
165-186: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor logging to the console.
188-211: LGTM!The test case correctly verifies the functionality of
verifyReturnUrlfor logging to the console with secure hash.test/build-payment-url.test.ts (1)
4-4: LGTM! Ensure consistent usage ofgetDateInGMT7.The import statement has been updated to include
getDateInGMT7. This change is approved.Ensure that all occurrences of date handling in the test suite use this function for consistency.
src/vnpay.ts (6)
Line range hint
474-474:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
refundmatch the new logic.Verification successful
Function usage verified successfully.
The
refundfunction calls in the codebase match the new logic as expected. No issues were found.
example/index.ts: Therefundfunction is called with the correct parameters.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `refund` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type typescript -A 5 $'refund'Length of output: 69
Script:
#!/bin/bash # Description: Verify all function calls to `refund` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type ts -A 5 $'refund'Length of output: 6452
16-16: LGTM! Ensure consistent usage ofgetDateInGMT7.The import statement has been updated to include
getDateInGMT7. This change is approved.Ensure that all occurrences of date handling in the codebase use this function for consistency.
Verification successful
Consistent Usage of
getDateInGMT7VerifiedThe function
getDateInGMT7is consistently used across the codebase for date handling in GMT+7. This includes its usage in the main implementation as well as in test files.
- Occurrences:
src/vnpay.tssrc/utils/common.tstest/build-payment-url.test.tstest/utils/common.test.tsThis ensures that date handling is standardized across the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all occurrences of date handling use `getDateInGMT7`. # Test: Search for the function usage. Expect: Only occurrences of `getDateInGMT7`. rg --type typescript -A 5 $'getDateInGMT7'Length of output: 76
Script:
#!/bin/bash # Description: Verify all occurrences of date handling use `getDateInGMT7`. # Test: Search for the function usage. Expect: Only occurrences of `getDateInGMT7`. rg --type ts -A 5 'getDateInGMT7'Length of output: 2747
246-262: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
verifyReturnUrlmatch the new logic.
Line range hint
354-354:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
queryDrmatch the new logic.Verification successful
Function
queryDrusage verification:The function
queryDris used correctly in the following files:
src/vnpay.ts: Method definition and internal usage.example/index.ts: External function call.The usage in
example/index.tsaligns with the new logic defined insrc/vnpay.ts.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `queryDr` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type typescript -A 5 $'queryDr'Length of output: 70
Script:
#!/bin/bash # Description: Verify all function calls to `queryDr` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type ts -A 5 $'queryDr'Length of output: 1200
194-198: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
buildPaymentUrlmatch the new logic.Verification successful
Function usage verified
The function calls to
buildPaymentUrlhave been verified, and they match the new logic of multiplyingvnp_Amountby 100.
- The tests in
test/build-payment-url.test.tsconfirm the correct implementation.- Example usages in
example/index.tsandexample/express.tsalso align with the new logic.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `buildPaymentUrl` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type typescript -A 5 $'buildPaymentUrl'Length of output: 78
Script:
#!/bin/bash # Description: Verify all function calls to `buildPaymentUrl` match the new logic. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type ts -A 5 $'buildPaymentUrl'Length of output: 10182
Line range hint
296-296:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
verifyIpnCallmatch the new logic.
Summary by Sourcery
This pull request refactors the VNPay class for better readability and maintainability, introduces new utility functions for date handling and secure hash calculation, and updates the logging functionality. It also includes updates to tests and configuration files.
getDateInGMT7and updatingparseDateto support different time zones.consoleLoggerto specify the console method to use.payment.util.ts.getDateInGMT7function for consistent date handling..coderabbit.yamlconfiguration to include tone instructions for feedback.Summary by CodeRabbit
New Features
Bug Fixes
Tests