Conversation
kwsantiago
suggested changes
Jan 20, 2026
src/network.zig
Outdated
Comment on lines
146
to
152
| fn isCommandArg(arg: []const u8) bool { | ||
| return std.mem.eql(u8, arg, "broadcast") or | ||
| std.mem.eql(u8, arg, "explore") or | ||
| std.mem.eql(u8, arg, "help") or | ||
| std.mem.eql(u8, arg, "--help") or | ||
| std.mem.eql(u8, arg, "-h"); | ||
| } |
Contributor
There was a problem hiding this comment.
Missing discover command. Running yam --signet discover will incorrectly treat "discover" as a custom challenge hex, fail to parse it, and return an error.
Contributor
Author
There was a problem hiding this comment.
Great catch thank you. This also demonstrated how invasive adding signet as a flag is. I changed it to an environment variable so it's less disruptive to overall logic / usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this moves the default port and network magic to global vars that are initialized on startup. it might be more elegant in the future to thread those values through the program but I wanted to optimize for minimal changes to existing logic
tested the basics of discover, connecting, and mempool with mainnet, default signet, and a custom signet