Skip to content

Commit

Permalink
Add description field to SaveNativeLangRequest (#467)
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidSGK authored Sep 29, 2024
1 parent 3a6e7b7 commit 5f5daaa
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions proto/lekko/bff/v1beta1/bff.proto
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ message GetRepositoryContentsResponse {
message GetNativeLangRequest {
BranchKey key = 1;
string namespace_name = 2;
// full language name, lowercase: go, typescript, python, etc.
// Full language name, lowercase: go, typescript, python, etc.
string language = 3;
}

Expand Down Expand Up @@ -814,16 +814,21 @@ message SaveStarlarkResponse {
message SaveNativeLangRequest {
BranchKey key = 1;
string namespace_name = 2;
// Full language name, lowercase: go, typescript, python, etc.
string language = 3;
string code = 4;
// Human-friendly description of changes. If not set, a default description will be generated.
string description = 5;
}

// TODO: We probably want some kind of linting/checking endpoint that surfaces diagnostic errors
// if parsing native lang code fails, so that the editor can show in-code errors or suggest fixes.
// This could be part of SaveNativeLang with a dry_run-esque option or a separate endpoint.
message SaveNativeLangResponse {
// A new branch is automatically created if this save was based on a default branch
Branch branch = 1;
// The formatted code after save
string formatted = 2;
// TODO: We probably want some kind of linting/checking endpoint that surfaces diagnostic errors
// if parsing native lang code fails, so that the editor can show in-code errors or suggest fixes.
// This could be part of SaveNativeLang with a dry_run-esque option or a separate endpoint.
}

message ConvertRuleToStringRequest {
Expand Down

0 comments on commit 5f5daaa

Please sign in to comment.