Add proto definitions for API key scopes RPCs #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passichenko
reviewed
Oct 12, 2023
proto/lekko/bff/v1beta1/bff.proto
Outdated
| } | ||
|
|
||
| message ListAPIKeyScopesResponse { | ||
| repeated Namespace namespaces = 1; |
There was a problem hiding this comment.
nit: it took me a bit to understand that this is a list of namespaces that requested api key is scoped to, maybe give it a bit more descriptive name? Like enabled_namespaces or scoped_to_namespaces.
Also do we need to pass a full namespace object here? May be just names would be enough? I guess it depends on how it will be used.
There was a problem hiding this comment.
Sure, I can change the name to be more descriptive!
There was a problem hiding this comment.
We're not actually returning the full namespace object, Namespace is a new message type I added as part of this PR and it basically only contains the repo key (which is gh owner, repo name, team name) and namespace name.
passichenko
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Task
To support frontend SDK clients using API keys without potentially exposing all of their configs, we need to implement scoping API keys. We start with implementing scoping keys to namespaces.
Details