Add metadata field to config model #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passichenko
changed the title
DavidSGK
reviewed
Oct 20, 2023
| @@ -30,6 +31,7 @@ message Feature { | |||
| string description = 2; | |||
| Tree tree = 3; | |||
| FeatureType type = 4; | |||
| google.protobuf.Value metadata = 7; | |||
There was a problem hiding this comment.
If we're enforcing that metadata needs to be a dict in starlark, can't we explicitly use the Struct type instead of Value?
DavidSGK
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is needed for https://github.com/lekkodev/webapp/pull/358
The idea is to add a generic metadata field to store arbitrary json and persist it in starlark. It can be used for any unstructured data for prototypes / experimental features.
Change
metadatafields to protosCompatibility
This is a breaking change, so it requires namespace version upgrade.
Testing