init for node.js #448
Merged
init for node.js #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
passichenko
commented
Jul 18, 2024
•
passichenko
commented
- if there is no react dep and it's not vite or next, assume that it's a node backend
- logic is mostly copy-paste from vite
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @passichenko and the rest of your teammates on |
DavidSGK
approved these changes
Jul 18, 2024
| } | ||
| spin.Stop() | ||
| fmt.Printf("%s Successfully installed @lekko/js-sdk.\n", successCheck) | ||
| nextSteps["Node.js SDK"] = append(nextSteps["Node.js SDK"], "See https://docs.lekko.com/sdks/node-sdk to get started") |
There was a problem hiding this comment.
Looks like the current URL for our node docs is https://docs.lekko.com/sdks/node-server-sdk, not sure if this is a typo or if you were planning on changing the title/URL in docs.
There was a problem hiding this comment.
yeah, I renamed it to make it more consistent with other urls
passichenko
force-pushed
the
07-18-init_for_node.js
branch
from
fffb37b to
882f7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.