Repoless gen for TS #462
Merged
Repoless gen for TS #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSGK
commented
Sep 26, 2024
| } | ||
|
|
||
| // Output is expected to be base64 encoded serialized RepositoryContents message | ||
| func syncTSOutputToRepositoryContents(output []byte) (*featurev1beta1.RepositoryContents, error) { |
There was a problem hiding this comment.
This was moved to be repo/contents/DecodeRepositoryContents
lekko-jonathan
approved these changes
Sep 26, 2024
|
It probably makes sense to commit this one before 463 since they collide, but 463 will be trivial to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated TS code generation methods to allow generating from repo contents instead of relying on local repository.
GenTSintoGenTS(this will essentially be used as a library) andGenTSFromLocalDecodeRepositoryContentsmethodlekko gen tsto take encoded repo contents and output generated TS code