Skip to content

Migrate github.com/bufbuild/connect-go to connectrpc.com/connect #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

DavidSGK
Copy link
Member

@DavidSGK DavidSGK commented Sep 26, 2024

As described on https://github.com/bufbuild/connect-go, this package has stopped being maintained and been moved. I was running into some issues trying to use some recently changed generated code so decided we should follow the recommendation and migrate.

Making changes here first since the CLI gets imported as a library in core.

On a related note, you can't really use both github.com/bufbuild/connect-go and connectrpc.com/connect at the same time, you get errors like this:

panic: proto: file "connectext/grpc/status/v1/status.proto" is already registered
       previously from: "connectrpc.com/connect/internal/gen/connectext/grpc/status/v1"
       currently from:  "github.com/bufbuild/connect-go/internal/gen/connectext/grpc/status/v1"
See https://protobuf.dev/reference/go/faq#namespace-conflict

which is why this is a wholesale change.

@DavidSGK DavidSGK self-assigned this Sep 26, 2024
@DavidSGK DavidSGK merged commit 6403b17 into main Sep 26, 2024
1 check passed
@DavidSGK DavidSGK deleted the david/migrate-connectrpc branch September 26, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant