legit/porcelain: signal a lem:editor-error #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> ERROR is treated as an editor bug when the command loop catches it. and editor-error is more friendly.
cxxxr
reviewed
Jan 4, 2024
| (defun %editor-error (message &rest args) | ||
| "Signal a lem:editor-error condition if the :lem package exists, otherwise signal a simple error. | ||
| This helps avoiding a tight dependency on Lem in the porcelain package." | ||
| (let ((msg (apply #'format nil message args))) |
There was a problem hiding this comment.
uiop:symbol-call only fools the compiler and actually makes it dependent on lem.
Besides, this kind of pattern is troublesome when refactoring and should be avoided if possible.
I have a suggestion, how about the following?
- define porcelain condition
(define-condition porcelain-error (error) ...)- Call that porcelain-error on this line.
(error 'porcelain-error ...)- Each define-command handles porcelain-error, converts it to editor-error, and lifts it up.
(define-command legit-... (...) (...)
(with-porcelain-error () ...))or
(defclass legit-advice () ())
(defmethod execute (mode (command legit-advice) argument)
(with-porcelain-error () (call-next-method)))
(define-command (legit-... :advice-classes legit-advice) () ())
...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per your review on #1198