Enable coalton-mode inside coalton-toplevel in lisp-mode.

[fukamachi]

I need help to make coalton-mode work as a sub-mode of lisp-mode.

I'm using after-syntax-scan-hook to enable coalton-mode partially only inside coalton-toplevel, however it doesn't work for some reason.

Enable coalton-mode (added in #1744) as a submode inside coalton-toplevel in lisp-mode.

For example, in the following file, the type Integer should be highlighted even in lisp-mode.

;; Just for testing: test.lisp
(defpackage foo
  (:use :coalton-prelude))
(in-package :foo)

(coalton-toplevel
  (declare foo (Integer -> Integer))
  ...
  )

TODO

• Make it work even in the middle of coalton-toplevel by looking backward

[cxxxr]

It appears that recursive-check needs to be set to nil.

diff --git a/extensions/coalton-mode/coalton-mode.lisp b/extensions/coalton-mode/coalton-mode.lisp
index ba083762..dd7d0849 100644
--- a/extensions/coalton-mode/coalton-mode.lisp
+++ b/extensions/coalton-mode/coalton-mode.lisp
@@ -350,6 +350,7 @@
     (lem-lisp-mode/autodoc:lisp-autodoc)))

 (defun after-syntax-scan (start end)
+  (ignore-errors
     (when (eq 'lem-lisp-mode:lisp-mode
               (buffer-major-mode (point-buffer start)))
       (with-point ((p start))
@@ -361,6 +362,7 @@
                    (lem:character-offset p -1)
                    (set-region-major-mode start p 'coalton-mode)
                    (syntax-scan-region start p
-                                     :syntax-table *syntax-table*))))))
+                                       :syntax-table *syntax-table*
+                                       :recursive-check nil)))))))

[fukamachi]

@cxxxr Thanks! I've fixed it to work correctly.

[fukamachi]

@cxxxr Is it possible to make it work even if (coalton-toplevel is far away at the top of the viewport?

(coalton-toplevel


;;; A lot of Coalton code.......
;;;
;;; ***
;;; and it is like here is the beginning line of the view port.

  (declare fib (Integer -> Integer))

  )

I changed the code to scan a list backward, but it throws a control stack overflow at syntax-scan-region.

[cxxxr]

I sse, this worked.

❯ git diff -w
diff --git a/extensions/coalton-mode/coalton-mode.lisp b/extensions/coalton-mode/coalton-mode.lisp
index dede144d..a5559c6b 100644
--- a/extensions/coalton-mode/coalton-mode.lisp
+++ b/extensions/coalton-mode/coalton-mode.lisp
@@ -350,11 +350,15 @@
   (when (eql #\space (get-self-insert-char))
     (lem-lisp-mode/autodoc:lisp-autodoc)))

+(defvar *recursive* nil)
+
 (defun after-syntax-scan (start end)
+  (unless *recursive*
     (ignore-errors
       (when (eq 'lem-lisp-mode:lisp-mode
                 (buffer-major-mode (point-buffer start)))
         (with-point ((p start))
+          (lem-lisp-syntax:beginning-of-defun p -1)
           (loop while (lem:search-forward p "(coalton-toplevel" end)
                 unless (lem:in-string-or-comment-p p)
                 do (with-point ((start p))
@@ -362,8 +366,9 @@
                      (lem:scan-lists p 1 0)
                      (lem:character-offset p -1)
                      (set-region-major-mode start p 'coalton-mode)
+                     (let ((*recursive* t))
                        (syntax-scan-region start p
                                            :syntax-table *syntax-table*
-                                       :recursive-check nil)))))))
+                                           :recursive-check nil)))))))))

 (add-hook (variable-value 'after-syntax-scan-hook :global) 'after-syntax-scan)

[fukamachi]

Fantastic! Thank you!

[cxxxr]

Can I merge this PR?

[fukamachi]

Can I merge this PR?

Absolutely, if it looks fine to you!

[fukamachi]

Thank you for your support. 🙂