Combine Dev Shells & Fix Pure Build #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL2 is not very heavy to include for all users. This way, no switching shells is necessary to build Lem or LemSDL2 pkg-config is a requirement. Including packages in the LD_LIBRARY_PATH list does not appear to run the pkg-config hook, so anything where pkg-config is run needs to be in the package list.
Most systems already have this, but it's pretty cheap to make sure. Not relying on any incidental resources is the Nix way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version includes everything necessary to build inside a pure container with just a working nix installation.
nix develop
make sdl2
make sdl
Since the extra stuff for ncurses or SDL isn't very big, it makes sense to only use one dev shell with a bit of redundancy. Users won't have to remember to switch shells.
nix developis easier to remember.