Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure project #50

Merged
merged 43 commits into from
May 18, 2024
Merged

Restructure project #50

merged 43 commits into from
May 18, 2024

Conversation

lemonyte
Copy link
Owner

@lemonyte lemonyte commented Mar 20, 2024 •
edited by mikepal2
Loading

  • use src layout
  • split bcferries package into multiple modules
  • replace MD5 hash with SHA-1
  • fix typing issues
  • split data into files by data type
  • restore ConnectionType
  • refactor function signatures with pos-only and kwarg-only params
  • fix RoutePlanSegment.connection type hint
  • fix Pydantic serialization warnings
  • test for bugs

lemonyte added 20 commits March 20, 2024 12:09
@lemonyte
Restructure project
42e75a5 
- use src layout
- split bcferries package into multiple modules
@lemonyte
Merge branch 'main' into restructure
0690495
@lemonyte
Split data files by data type
83f1a61
@lemonyte
Switch to src layout, restructure code into modules
829d26d
@lemonyte
pre-commit autoupdate
a05a71a
@lemonyte
Fix cache gitignore
010d5fd
@lemonyte
Use generic type hints in server.py
2351ea8
@lemonyte
Update schedule api route
eceea58 
- rename to ferry_schedule
- return documented response when schedule is not found
@lemonyte
Rename ScheduleCache to ScheduleDB
e627b29
@lemonyte
Update options.py
466de2f 
- use LocationId instead of str
- add docstring to RoutePlansOptions.buffer
@lemonyte
Update Terminal docstrings
c8f0a6c
@lemonyte
Refactored schedule module
30c1c9d
@lemonyte
Refactor connection module
e7f2102
@lemonyte
Add data DB module
0c3d064
@lemonyte
Refactor route module
f327a9e
@lemonyte
Use absolute imports for ferry_planner modules
b311b85
@lemonyte
Fix: attribute defined outside of __init__
7b04c92
@lemonyte
Fix redefinition of builtin hash function
392bd39
@lemonyte
Remove unnecessary None default
f03205f
@lemonyte
Fix incorrect times order for sailings
88ccc8f
@lemonyte lemonyte marked this pull request as ready for review May 7, 2024 06:40
@lemonyte lemonyte requested a review from mikepal2 May 7, 2024 06:40
@lemonyte lemonyte added area: backend Server and other backend components area: data Related to data used by the server area: meta Related to the repo itself, configuration, workflows, etc labels May 7, 2024
@lemonyte lemonyte self-assigned this May 7, 2024
@lemonyte lemonyte requested a review from mikepal2 May 12, 2024 23:03
@mikepal2 mikepal2 merged commit 5abaf76 into main May 18, 2024
5 of 7 checks passed
@mikepal2 mikepal2 deleted the restructure branch May 18, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepal2 mikepal2 mikepal2 approved these changes

Assignees

@lemonyte lemonyte

Labels
area: backend Server and other backend components area: data Related to data used by the server area: meta Related to the repo itself, configuration, workflows, etc
Projects
Ferry Planner Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemonyte @mikepal2